----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32435/#review77946 -----------------------------------------------------------
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroObjectInspectorGenerator.java <https://reviews.apache.org/r/32435/#comment126306> Could this be static? - Xuefu Zhang On March 24, 2015, 11:08 a.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32435/ > ----------------------------------------------------------- > > (Updated March 24, 2015, 11:08 a.m.) > > > Review request for hive, Brock Noland, Szehon Ho, and Xuefu Zhang. > > > Bugs: HIVE-10027 > https://issues.apache.org/jira/browse/HIVE-10027 > > > Repository: hive-git > > > Description > ------- > > This patch supports to use the "doc" tag description in Avro schema fields or > the column comment in Arvo table DDL as table column comments. Currently they > are using the default "from deserializer" hardcoded in Hive MetaStoreUtil. > > > Diffs > ----- > > ql/src/test/queries/clientpositive/avro_comments.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_compression_enabled.q > cb6f173ccfa76420f07c7d7e69749482537127aa > ql/src/test/queries/clientpositive/avro_evolved_schemas.q > 59cb21053fbb366962e39126f4f6623b8d53c8e0 > ql/src/test/queries/clientpositive/avro_joins.q > 6d79bf1c1b4b403b6f33047dbe56ad656a68f990 > ql/src/test/results/clientpositive/avro_add_column.q.out > 3aae56225ad671e44291d566b4a2400a9ee4ead9 > ql/src/test/results/clientpositive/avro_add_column2.q.out > 0e26cd59f3969898f0cd2d47ae4d271fe39824f3 > ql/src/test/results/clientpositive/avro_add_column3.q.out > 0418b29ca95e71dca0b46bc3bd26bb1564192d1e > ql/src/test/results/clientpositive/avro_change_schema.q.out > 5d52d215471527b00c5a277ddb77160249ea44a1 > ql/src/test/results/clientpositive/avro_comments.q.out PRE-CREATION > ql/src/test/results/clientpositive/avro_compression_enabled.q.out > bcb967a11516b33eac045d160f88946606ce75f7 > ql/src/test/results/clientpositive/avro_decimal.q.out > 88268ceb3a5dddc50d48b502dba17647f8d8e5fe > ql/src/test/results/clientpositive/avro_decimal_native.q.out > c8ae0fb2404c8891c4e307d82d1c2d7f180eae51 > ql/src/test/results/clientpositive/avro_evolved_schemas.q.out > 2f81b1ab9a6a266318945135726de7d23c809d8c > ql/src/test/results/clientpositive/avro_joins.q.out > 7e47fe0f25ad9b90971c26fc1fee95ceb32c0862 > ql/src/test/results/clientpositive/avro_joins_native.q.out > ca22a7279bc285600ffa40f76707fdd7e94dbb23 > ql/src/test/results/clientpositive/avro_native.q.out > 2de4df1b8452e0b091a8ce3b6f5a9369ff208290 > ql/src/test/results/clientpositive/avro_partitioned.q.out > 890cd9f764e35f9d99b42a7083f0bb49e2ec7bab > ql/src/test/results/clientpositive/avro_partitioned_native.q.out > c02c656a45d54065280c4a30c0179f15d9a49267 > ql/src/test/results/clientpositive/avro_sanity_test.q.out > 687579e69ba9d48bc471a89a7322f403eefce14a > ql/src/test/results/clientpositive/avro_schema_evolution_native.q.out > 84d8051422b032965dbd7f9b4e0892ead76f1b67 > ql/src/test/results/clientpositive/avro_schema_literal.q.out > b13694d16096a89c62aec82eceb057b47c2c4878 > ql/src/test/results/clientpositive/create_like.q.out > 5e6836753effd84fc4e932ffc80a29b780613a23 > ql/src/test/results/clientpositive/index_serde.q.out > c0fc7e529a70ff8abfcc68bcd4e0e40e1cf87098 > ql/src/test/results/clientpositive/spark/avro_decimal_native.q.out > c8ae0fb2404c8891c4e307d82d1c2d7f180eae51 > ql/src/test/results/clientpositive/spark/avro_joins.q.out > 7e47fe0f25ad9b90971c26fc1fee95ceb32c0862 > ql/src/test/results/clientpositive/spark/avro_joins_native.q.out > ca22a7279bc285600ffa40f76707fdd7e94dbb23 > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroObjectInspectorGenerator.java > 64a65433c7b476f8241e816e6c6fa20561872981 > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java > 8ba0692c0a24b876f6087d90aceb744d1dcd94be > > Diff: https://reviews.apache.org/r/32435/diff/ > > > Testing > ------- > > 1. Manaul tests all passed > 2. New qfile test avro_comments passed > 3. Precommit build tests passed > > > Thanks, > > Chaoyu Tang > >
