----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33367/#review81119 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/AggregateStatsCache.java <https://reviews.apache.org/r/33367/#comment131370> this is not being set to false, which means the cleaner would run only once. metastore/src/java/org/apache/hadoop/hive/metastore/AggregateStatsCache.java <https://reviews.apache.org/r/33367/#comment131371> For tracking how the cache is performing, would be useful to have an INFO level message about how many entries were there and how many were removed due to expiry and if the eviction based on LRU is going to be triggered. metastore/src/java/org/apache/hadoop/hive/metastore/AggregateStatsCache.java <https://reviews.apache.org/r/33367/#comment131372> evicting one LRU node at a time is expensive. I think we should just reduce the TTL to 0.9*TTL , 0.8*TTL etc and call this function again. Can be done in a follow up jira. Ideally, in the long term, we should think of using both the frequency of use and cost of re-computing the stats while deciding which ones to evict. - Thejas Nair On April 20, 2015, 6:44 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33367/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 6:44 p.m.) > > > Review request for hive. > > > Bugs: HIVE-10382 > https://issues.apache.org/jira/browse/HIVE-10382 > > > Repository: hive-git > > > Description > ------- > > Similar to the work done on the HBase branch (HIVE-9693), the stats cache can > potentially have performance gains. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 65ec1b9 > common/src/java/org/apache/hive/common/util/BloomFilter.java PRE-CREATION > common/src/java/org/apache/hive/common/util/Murmur3.java PRE-CREATION > common/src/test/org/apache/hive/common/util/TestBloomFilter.java > PRE-CREATION > common/src/test/org/apache/hive/common/util/TestMurmur3.java PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/AggregateStatsCache.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > bf169c9 > > metastore/src/test/org/apache/hadoop/hive/metastore/TestAggregateStatsCache.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/io/filters/BloomFilter.java 6ab0270 > ql/src/java/org/apache/hadoop/hive/ql/io/filters/BloomFilterIO.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/io/filters/Murmur3.java e733892 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/FileDump.java 7bfd781 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFile.java 49a8e80 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java bde9fc2 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java a319204 > ql/src/test/org/apache/hadoop/hive/ql/io/filters/TestBloomFilter.java > 32b95ab > ql/src/test/org/apache/hadoop/hive/ql/io/filters/TestMurmur3.java d92a3ce > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestRecordReaderImpl.java > d0f3a5e > > Diff: https://reviews.apache.org/r/33367/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
