----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33816/#review82466 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java <https://reviews.apache.org/r/33816/#comment133201> Update comment to explain behavior of absolute vs relative paths. metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java <https://reviews.apache.org/r/33816/#comment133204> I don't think we want to handle relative paths for this particular bug - instead throw an error. Since this function is called in multiple places, be sure nothing else is expected to work with relative paths. Please add test case(s) as well - Lenni Kuff On May 4, 2015, 7:05 p.m., Reuben Kuhnert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33816/ > ----------------------------------------------------------- > > (Updated May 4, 2015, 7:05 p.m.) > > > Review request for hive and Sergio Pena. > > > Bugs: HIVE-10597 > https://issues.apache.org/jira/browse/HIVE-10597 > > > Repository: hive-git > > > Description > ------- > > Allow warehouse to work with relative locations. > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java > 25119abf97382df7c0615edbaff29ba20624a137 > > Diff: https://reviews.apache.org/r/33816/diff/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Reuben Kuhnert > >
