----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33956/ -----------------------------------------------------------
Review request for hive, Brock Noland and cheng xu. Bugs: HIVE-9614 https://issues.apache.org/jira/browse/HIVE-9614 Repository: hive-git Description ------- The security issue here is that encrypted tables used on MAP-JOIN queries, and stored on the distribute cache, are first copied to the client local filesystem in an unencrypted form in order to compress it there. This patch avoids the local copy if the table is encrypted on HDFS. It keeps the hash table on HDFS, compresses the table in HDFS, and then adds it to the distributed cache. Files that are copied to the datanodes by the distributed cache are still unencrypted. This is a limitation we have from HDFS. Diffs ----- common/src/java/org/apache/hadoop/hive/common/CompressionUtils.java 0e0d538c2faf1c52c4d8378df013294ae4efa41c common/src/java/org/apache/hive/common/util/HdfsEncryptionUtilities.java PRE-CREATION itests/src/test/resources/testconfiguration.properties 3eff7d010923a4e07d5024904f1531ca52473aa2 ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java ad5c8f8302de2a15b1703161799f71cd81a94475 ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java d7a08ecf1c183fe56b5ca41c2c69d413874418bb ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 4d84f0f76ce17711077ceadf23e6b9ed12e6a414 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MapJoinResolver.java c0a72b69df3871bbcc870af286774aee5269668b ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cbc5466261f749fe7b84d7533dc0ff3274b6777f ql/src/java/org/apache/hadoop/hive/ql/plan/MapredLocalWork.java 82143a64db163da766dcc138231b4d4174603470 ql/src/test/queries/clientpositive/encryption_map_join_select.q PRE-CREATION ql/src/test/results/clientpositive/encrypted/encryption_map_join_select.q.out PRE-CREATION Diff: https://reviews.apache.org/r/33956/diff/ Testing ------- Thanks, Sergio Pena