----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34393/#review84260 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCollectSet.java <https://reviews.apache.org/r/34393/#comment135437> should we also support arrays and unions? ql/src/test/queries/clientpositive/udaf_collect_list_set_nested.q <https://reviews.apache.org/r/34393/#comment135438> add a negative test to validate unsupported types? - Lenni Kuff On May 19, 2015, 4:47 a.m., Chao Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34393/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 4:47 a.m.) > > > Review request for hive. > > > Bugs: HIVE-10427 > https://issues.apache.org/jira/browse/HIVE-10427 > > > Repository: hive-git > > > Description > ------- > > Currently for collect_list() and collect_set(), only primitive types are > supported. This patch adds support for struct and map types as well. > > It turned out I that all I need is loosen the type checking. > > > Diffs > ----- > > data/files/customers.txt PRE-CREATION > data/files/nested_orders.txt PRE-CREATION > data/files/orders.txt PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCollectList.java > 536c4a7 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCollectSet.java > 6dc424a > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java > efcc8f5 > ql/src/test/queries/clientpositive/udaf_collect_list_set_nested.q > PRE-CREATION > ql/src/test/results/clientpositive/udaf_collect_list_set_nested.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/34393/diff/ > > > Testing > ------- > > All but one test (which seems unrelated) are passing. > I also added a test: udaf_collect_list_set_nested.q > > > Thanks, > > Chao Sun > >
