----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34385/#review84391 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java <https://reviews.apache.org/r/34385/#comment135616> I see that these jiras have been committed and better to remove these comments. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java <https://reviews.apache.org/r/34385/#comment135622> This is dead code, but I think removing this idea alltogether will disable vectorization when there is a cast of a constant to boolean because the VectorExpression returned from this function will be null. I think a better alternative would be to make this code live by putting this inside if (child instanceof ExprNodeConstantDesc) to enable vectorization when the child has already a NULL object. What do you think ? ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java <https://reviews.apache.org/r/34385/#comment135625> Can we have a brief explanation as to why we cannot vectorize Custom UDF in the exception message, will help debugging better since there are 2 similar messages not too far apart. Apart from the minor comments above, the changes look good to me. Thanks Hari - Hari Sankar Sivarama Subramaniyan On May 19, 2015, 9:14 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34385/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 9:14 p.m.) > > > Review request for hive and Gopal V. > > > Bugs: HIVE-10745 > https://issues.apache.org/jira/browse/HIVE-10745 > > > Repository: hive-git > > > Description > ------- > > Better null handling by Vectorizer > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java > f08321c > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > 48f34a9 > > Diff: https://reviews.apache.org/r/34385/diff/ > > > Testing > ------- > > > Thanks, > > Ashutosh Chauhan > >
