> On May 27, 2015, 10:13 p.m., Xuefu Zhang wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 2062 > > <https://reviews.apache.org/r/34455/diff/3/?file=972428#file972428line2062> > > > > Sorry for pointing this out late. I'm not certain if it's a good idea > > to expose these two configurations. Also this introduces a change of > > behavior. For now, can we get rid of them and change the persistency level > > back to MEM+DISK? > > > > We can come back to revisit this later on. At this moment, I don't feel > > confident to make the call. > > chengxiang li wrote: > persistent to MEM + DISK may hurt the performance in certain cases, i > think at least we should have a switch to open/close this optimization,
Agreed. However, before we find out more about in what cases this helps or hurts, I think it's better we keep the existing behavior. This doesn't prevent us from adding a flag later on. - Xuefu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34455/#review85451 ----------------------------------------------------------- On May 27, 2015, 1:50 a.m., chengxiang li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34455/ > ----------------------------------------------------------- > > (Updated May 27, 2015, 1:50 a.m.) > > > Review request for hive, Chao Sun, Jimmy Xiang, and Xuefu Zhang. > > > Bugs: HIVE-10550 > https://issues.apache.org/jira/browse/HIVE-10550 > > > Repository: hive-git > > > Description > ------- > > see jira description > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 43c53fc > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/CacheTran.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/MapTran.java 2170243 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ReduceTran.java e60dfac > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java ee5c78a > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java > 3f240f5 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkUtilities.java > e6c845c > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkRddCachingResolver.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java > 19aae70 > ql/src/java/org/apache/hadoop/hive/ql/plan/SparkWork.java bb5dd79 > > Diff: https://reviews.apache.org/r/34455/diff/ > > > Testing > ------- > > > Thanks, > > chengxiang li > >
