-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34727/
-----------------------------------------------------------
(Updated May 29, 2015, 11:44 a.m.)
Review request for hive, Szehon Ho, Thejas Nair, and Xuefu Zhang.
Changes
-------
Updated the patch:
1. Add a unit test TestJdbcWithMiniHS2#testConcurrentStatements (300 tasks
using 100 threads, take around 1.5 -2 min in my local machine)
2. use the client object itself as the lock
Bugs: HIVE-10835
https://issues.apache.org/jira/browse/HIVE-10835
Repository: hive-git
Description
-------
There exist race conditions between DatabaseMetaData, Statement and ResultSet
when they make RPC calls to HS2 using same Thrift transport, which happens
within same connection.
The patch is to have a connection level lock to serialize the RPC calls within
a single connection.
Diffs (updated)
-----
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java
7210480
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 1b2891b
jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java e93795a
jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 6b3d05c
Diff: https://reviews.apache.org/r/34727/diff/
Testing
-------
Some multi-thread tests (80 threads for 200 iterations)
Thanks,
Chaoyu Tang
