----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35107/#review89251 -----------------------------------------------------------
beeline/src/java/org/apache/hive/beeline/Commands.java (line 717) <https://reviews.apache.org/r/35107/#comment141839> Nit: method naming. substitution() -> substituteVariables() or substitue() beeline/src/java/org/apache/hive/beeline/Commands.java (line 791) <https://reviews.apache.org/r/35107/#comment141854> Do we need to close statement when done? beeline/src/java/org/apache/hive/beeline/Commands.java (line 814) <https://reviews.apache.org/r/35107/#comment141842> Does this mean that env and sys variables are not being substituted for shell command? beeline/src/java/org/apache/hive/beeline/Commands.java (line 861) <https://reviews.apache.org/r/35107/#comment141843> Don't we need to close reader object? ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java (line 145) <https://reviews.apache.org/r/35107/#comment141846> Could we keep @Override at a separate line? Same for other places. - Xuefu Zhang On June 24, 2015, 7:39 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35107/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 7:39 a.m.) > > > Review request for hive, chinna and Xuefu Zhang. > > > Bugs: HIVE-6791 > https://issues.apache.org/jira/browse/HIVE-6791 > > > Repository: hive-git > > > Description > ------- > > Summary: > 1) move the beeline-cli convertor to the place where cli is executed(class > **Commands**) > 2) support substitution for source command > 3) add some unit test for substitution > 4) add one way to get the configuration from HS2 > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java b7d2f2e > beeline/src/java/org/apache/hive/beeline/Commands.java a42baa3 > beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java 6cbb030 > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java d62fd5c > common/src/java/org/apache/hadoop/hive/conf/HiveVariableSource.java > PRE-CREATION > common/src/java/org/apache/hadoop/hive/conf/VariableSubstitution.java > PRE-CREATION > common/src/test/org/apache/hadoop/hive/conf/TestVariableSubstitution.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 338e755 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java > a5f0a7f > ql/src/java/org/apache/hadoop/hive/ql/parse/VariableSubstitution.java > e8b1d96 > ql/src/java/org/apache/hadoop/hive/ql/processors/AddResourceProcessor.java > 0558c53 > ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java > 25ce168 > > ql/src/java/org/apache/hadoop/hive/ql/processors/DeleteResourceProcessor.java > 9052c82 > ql/src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java cc0414d > ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java bc9254c > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > 33ee16b > > Diff: https://reviews.apache.org/r/35107/diff/ > > > Testing > ------- > > Unit test passed > > > Thanks, > > cheng xu > >
