----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34059/#review83846 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java (line 672) <https://reviews.apache.org/r/34059/#comment134936> Move this to ExprNodeUtils? ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java (line 210) <https://reviews.apache.org/r/34059/#comment134932> Minreducers for conservative estimation ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java (line 669) <https://reviews.apache.org/r/34059/#comment141831> Nit: typo initializion -> initialization ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java (line 691) <https://reviews.apache.org/r/34059/#comment141832> May want to remove this comment in case we don't need it. ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java (line 695) <https://reviews.apache.org/r/34059/#comment141833> Rename function to flattenExprList makes code easier to read. ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java (line 705) <https://reviews.apache.org/r/34059/#comment141834> Incomplete comment needs fixing. ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java (line 721) <https://reviews.apache.org/r/34059/#comment141835> Can you add comments as to why we need to do that? ql/src/java/org/apache/hadoop/hive/ql/exec/tez/KeyValuesFromKeyValue.java (line 26) <https://reviews.apache.org/r/34059/#comment141840> Can you add comments for describing the need/use of this class? ql/src/java/org/apache/hadoop/hive/ql/exec/tez/KeyValuesFromKeyValues.java (line 24) <https://reviews.apache.org/r/34059/#comment141841> Comments please. ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordSource.java (line 186) <https://reviews.apache.org/r/34059/#comment141870> Not sure if this is correct? Shouldn't this be true only if this is dynamically partitioned hash join? ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java (line 652) <https://reviews.apache.org/r/34059/#comment141884> Is there ">>" in the code here? - Vikram Dixit Kumaraswamy On June 22, 2015, 7:30 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34059/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 7:30 p.m.) > > > Review request for hive, Matt McCline and Vikram Dixit Kumaraswamy. > > > Bugs: HIVE-10673 > https://issues.apache.org/jira/browse/HIVE-10673 > > > Repository: hive-git > > > Description > ------- > > Reduce-side hash join (using MapJoinOperator), where the Tez inputs to the > reducer are unsorted. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 27f68df > itests/src/test/resources/testconfiguration.properties 7b7559a > ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 15cafdd > ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java d7f1b42 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/KeyValuesAdapter.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/KeyValuesFromKeyValue.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/KeyValuesFromKeyValues.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java > 545d7c6 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordSource.java > cdabe3a > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapJoinOperator.java > e9bd44a > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinCommonOperator.java > 4c8c4b1 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java > 5a87bd6 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java > 4d84f0f > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java > bca91dd > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezProcContext.java adc31ae > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 11c1df6 > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezWork.java 6db8220 > ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java a342738 > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java fb3c4a3 > ql/src/java/org/apache/hadoop/hive/ql/plan/MapJoinDesc.java cee9100 > ql/src/test/queries/clientpositive/tez_dynpart_hashjoin_1.q PRE-CREATION > ql/src/test/queries/clientpositive/tez_dynpart_hashjoin_2.q PRE-CREATION > ql/src/test/queries/clientpositive/tez_vector_dynpart_hashjoin_1.q > PRE-CREATION > ql/src/test/results/clientpositive/tez/tez_dynpart_hashjoin_1.q.out > PRE-CREATION > ql/src/test/results/clientpositive/tez/tez_dynpart_hashjoin_2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/tez/tez_vector_dynpart_hashjoin_1.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/34059/diff/ > > > Testing > ------- > > q-file tests added > > > Thanks, > > Jason Dere > >
