----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35803/#review89749 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 1059) <https://reviews.apache.org/r/35803/#comment142533> Indentation ... metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 1089) <https://reviews.apache.org/r/35803/#comment142535> Indentation.. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 1788) <https://reviews.apache.org/r/35803/#comment142541> Have you looked at MetaStoreDirectSql class to see if there is any potential query leaking? metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 3409) <https://reviews.apache.org/r/35803/#comment142539> Do we have to use a list of queryWrappers with each wrapper for a different listXXX call? If so, we need open eight queries for this removeRole methods. Could we use only one and reuse it? metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 3417) <https://reviews.apache.org/r/35803/#comment142538> Should listPrincipalGlobalGrants be passed in a queryWrapper as well? metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4765) <https://reviews.apache.org/r/35803/#comment142540> Is there any reason you need an additional list to hold the retrieved result? - Chaoyu Tang On June 26, 2015, 5:23 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35803/ > ----------------------------------------------------------- > > (Updated June 26, 2015, 5:23 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-10895 ObjectStore does not close Query objects in some calls, causing a > potential leak in some metastore db resources > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 417ecc8 > metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveMetaTool.java > d0ff329 > metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/35803/diff/ > > > Testing > ------- > > Testing has been done. > > > Thanks, > > Aihua Xu > >