----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36139/#review90252 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManager.java (line 124) <https://reviews.apache.org/r/36139/#comment143261> could you add more doc for the methods added (e.g., what the method is for (in more detail), and what are each of the parameters)? ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java (line 89) <https://reviews.apache.org/r/36139/#comment143263> long line. ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java (line 169) <https://reviews.apache.org/r/36139/#comment143260> this is not only used for unlocking database. maybe changed the error message. ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java (line 174) <https://reviews.apache.org/r/36139/#comment143264> this looks exactly the same as DDLTask#getHiveObject. Is there a way to get rid of the latter? ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java (line 189) <https://reviews.apache.org/r/36139/#comment143262> long line. - Chao Sun On July 2, 2015, 5:24 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36139/ > ----------------------------------------------------------- > > (Updated July 2, 2015, 5:24 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-11130 Refactoring the code so that HiveTxnManager interface will support > lock/unlock table/database object > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > 8bcf860d1f4b783352e84c3b9c988e061ab0b751 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManager.java > 2dd0c7df2a91c7e9f7e8b9825725ccddd463262b > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java > eccb8d1d5ae7a41f90800fe8d62875978c98b074 > > Diff: https://reviews.apache.org/r/36139/diff/ > > > Testing > ------- > > Test has been done. This work will be followed by HIVE-10984 to solve the > explicit lock table issue. > > > Thanks, > > Aihua Xu > >
