----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36335/#review91020 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java (line 1246) <https://reviews.apache.org/r/36335/#comment144238> Could you change the name of getSelectivity to getCardinality or some thing similar. This method is actually returning cardinality as opposed to selectivity. - John Pullokkaran On July 8, 2015, 10:10 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36335/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 10:10 p.m.) > > > Review request for hive, John Pullokkaran and Mostafa Mokhtar. > > > Repository: hive-git > > > Description > ------- > > The static fields in static class JoinStatsRule in StatsRulesProcFactory were > carried on in between different calls. It would be better to move it inside > the function, just like all the other StatsRuls do. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > 0982059 > > Diff: https://reviews.apache.org/r/36335/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
