> On July 28, 2015, 8:48 p.m., Chao Sun wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 1044 > > <https://reviews.apache.org/r/36893/diff/1/?file=1023588#file1023588line1044> > > > > If allTables.size() = 1, this doesn't seem to drop the only table.
You are right. I missed that. - Aihua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36893/#review93342 ----------------------------------------------------------- On July 28, 2015, 6:54 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36893/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 6:54 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-11258 The function drop_database_core() of HiveMetaStore.java may not > drop all the tables > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > ee2cea05fb3b4c9582b7b5ac9d5cd929d3b9ec1a > > Diff: https://reviews.apache.org/r/36893/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
