----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36942/#review93697 -----------------------------------------------------------
Looks good to me. Just one minor question. ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/ParquetFilterPredicateConverter.java (lines 103 - 104) <https://reviews.apache.org/r/36942/#comment148112> Why we need to create the leaf when columns is null? - cheng xu On July 31, 2015, 5:22 a.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36942/ > ----------------------------------------------------------- > > (Updated July 31, 2015, 5:22 a.m.) > > > Review request for hive, Aihua Xu, cheng xu, Dong Chen, and Szehon Ho. > > > Bugs: HIVE-11401 > https://issues.apache.org/jira/browse/HIVE-11401 > > > Repository: hive-git > > > Description > ------- > > The following patch reviews the predicate created by Hive, and removes any > column that does not belong to the Parquet schema, such as partitioned > columns. This way Parquet can filter the columns correctly. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/ParquetFilterPredicateConverter.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/ParquetRecordReaderWrapper.java > 49e52da2e26fd7213df1db88716eaee94cb536b8 > > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetRecordReaderWrapper.java > 87dd344534f09c7fc565fdc467ac82a51f37ebba > > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/read/TestParquetFilterPredicate.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestConvertAstToSearchArg.java > 85e952fb6855a2a03902ed971f54191837b32dac > ql/src/test/queries/clientpositive/parquet_predicate_pushdown.q > PRE-CREATION > ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/36942/diff/ > > > Testing > ------- > > Unit tests: TestParquetFilterPredicate.java > Integration tests: parquet_predicate_pushdown.q > > > Thanks, > > Sergio Pena > >
