----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37810/#review96749 -----------------------------------------------------------
Patch looks good. Just one question: instead of populating the user name in several places, is it possible to use the one stored in SessionState (by calling SessionState.get().getUserName() before creating the Driver)? - Chao Sun On Aug. 26, 2015, 8:14 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37810/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 8:14 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-10021 "Alter index rebuild" statements submitted through HiveServer2 > fail when Sentry is enabled > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/Context.java > ca0d487b8195da7c848a8212a5b869620ee857af > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > 4030075dc5393b60bff25c50a700ccffdb1720bc > ql/src/java/org/apache/hadoop/hive/ql/index/AbstractIndexHandler.java > 1d27306ef1a644e4ad37a73f6f9eeed92cf79a5a > ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java > e67996d3fba94e9ff33078f4bf7fd97141103138 > ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java > b076933b7bd6611cd4b678441cd1cc2b0e16786b > > ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java > 1dbe230917564d5c17c198a898d4de7b52adab3b > ql/src/java/org/apache/hadoop/hive/ql/optimizer/IndexUtils.java > 92cae67e9111d42b36594cf44a174fb9f0812a7a > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 9f8c756bed3811f04ec1dc8625f89724faab99ff > > Diff: https://reviews.apache.org/r/37810/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
