> On Aug. 31, 2015, 11:56 p.m., Sergey Shelukhin wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g, line 475 > > <https://reviews.apache.org/r/37620/diff/2/?file=1047868#file1047868line475> > > > > phase 4? :)
Well, seriously :) , in this phase, we only support clause (x,y..) in ((..),..., ()) and in the next phase, we will support clause (x,y..) in (select x,y from ...). Any comments/suggestions are welcome. :) - pengcheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37620/#review97207 ----------------------------------------------------------- On Sept. 1, 2015, midnight, pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37620/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2015, midnight) > > > Review request for hive and John Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > Current hive only support single column in clause, e.g., > {code}select * from src where col0 in (v1,v2,v3);{code} > We want it to support > {code}select * from src where (col0,col1+3) in > ((col0+v1,v2),(v3,v4-col1));{code} > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 64af7d1 > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsNegative.java > 61b5892 > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsPositive.java > 4c84e91 > ql/src/test/queries/clientpositive/char_udf1.q 8848609 > ql/src/test/queries/clientpositive/keyword_2.q PRE-CREATION > ql/src/test/queries/clientpositive/multi_column_in.q PRE-CREATION > ql/src/test/queries/clientpositive/varchar_udf1.q 395fb12 > ql/src/test/results/clientpositive/char_udf1.q.java1.7.out ced0132 > ql/src/test/results/clientpositive/keyword_2.q.out PRE-CREATION > ql/src/test/results/clientpositive/multi_column_in.q.out PRE-CREATION > ql/src/test/results/clientpositive/varchar_udf1.q.java1.7.out 96ba06e > > Diff: https://reviews.apache.org/r/37620/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
