> On Sept. 12, 2015, 1:23 a.m., Szehon Ho wrote: > > I dont know if you saw in the earlier comments, please add a test to the > > file 'FolderPermissionBase' to verify permission inheritance works with the > > feature.
Sorry, overlooked the comments. I added a test to cover this. The fix respect original design: destination partition folder inheritance original partition folder's permission. For the intermediate folders between destination partition folder and base table folder, if they do not exist, the permission inherit from base table folder's(the same behavior as when add a new partition), otherwise keep their original permission. - Yongzhi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38216/#review98723 ----------------------------------------------------------- On Sept. 12, 2015, 4:07 a.m., Yongzhi Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38216/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2015, 4:07 a.m.) > > > Review request for hive, Chao Sun, Szehon Ho, and Xuefu Zhang. > > > Bugs: HIVE-11745 > https://issues.apache.org/jira/browse/HIVE-11745 > > > Repository: hive-git > > > Description > ------- > > Alter table Exchange partition with multiple partition_spec does not work in > cluster mode because in rename, the parent folder for destination path does > not physically exist. Some files system(hdfs for instance) does not > support(or allow) this. Fix by create parent folder first. > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/FolderPermissionBase.java > f28edc66ea4644c5847ee6abe2e26306f9fbb43e > itests/src/test/resources/testconfiguration.properties > bed621d3eb74f01e54110552f68538afd228018d > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1840e76cc567e95e1942d912b8ab0db516d63a3b > ql/src/test/queries/clientpositive/exchgpartition2lel.q PRE-CREATION > ql/src/test/results/clientpositive/exchgpartition2lel.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/38216/diff/ > > > Testing > ------- > > Add minimr unit test. > > > Thanks, > > Yongzhi Chen > >
