----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38702/#review101132 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 5750) <https://reviews.apache.org/r/38702/#comment158471> MB copy is insanely fast (~12x) when compared to reflect. Following benchmark is for 64MB and 64KB. Its the allocation that is crazy crazy slow (200000x slower for 64MB, 27x for 64KB). Benchmark (size) Mode Cnt Score Error Units ReflectVsMemcpy.testBufCopy 67108864 thrpt 25 86966068.519 ± 1501387.237 ops/s ReflectVsMemcpy.testBufCopyWithAlloc 67108864 thrpt 25 35.514 ± 0.711 ops/s ReflectVsMemcpy.testReflect 67108864 thrpt 25 7103613.589 ± 211760.447 ops/s Benchmark (size) Mode Cnt Score Error Units ReflectVsMemcpy.testBufCopy 65536 thrpt 25 85291163.067 ± 1872790.512 ops/s ReflectVsMemcpy.testBufCopyWithAlloc 65536 thrpt 25 264797.235 ± 14828.412 ops/s ReflectVsMemcpy.testReflect 65536 thrpt 25 7183122.599 ± 114792.975 ops/s - Prasanth_J On Sept. 24, 2015, 1:03 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38702/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 1:03 a.m.) > > > Review request for hive and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f3e2168 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 815f499 > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 6f15fd0 > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > e4a6cdb > ql/pom.xml 36b3433 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 3511e73 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java > 87881b6 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 2500fb6 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java cc03df7 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java ab539c4 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 99896c6 > > Diff: https://reviews.apache.org/r/38702/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
