----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38894/#review101178 -----------------------------------------------------------
Ship it! Nice, this is a ton cleaner to use the util method! Thanks! - Szehon Ho On Sept. 30, 2015, 9:58 p.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38894/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2015, 9:58 p.m.) > > > Review request for hive, Sergio Pena and Szehon Ho. > > > Bugs: HIVE-11995 > https://issues.apache.org/jira/browse/HIVE-11995 > > > Repository: hive-git > > > Description > ------- > > Table and partition permissions are repetitively set in Hive.ReplaceFiles by > inheritFromTable which sometimes is not necessary and causing performance > issue. For example, in dyanamically insert/load overwrite multiple level of > partitions (e.g. table/p1/p2/p3/p4), the p1,p2 p3 permissions are set > repetitively. > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/FolderPermissionBase.java > d98082f > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 10cafb6 > > Diff: https://reviews.apache.org/r/38894/diff/ > > > Testing > ------- > > TestExtendedAcls and TestFolderPermissions have existing test cases which > passed in my local machine. > Submitted for precommit build > > > Thanks, > > Chaoyu Tang > >
