----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40785/#review108573 -----------------------------------------------------------
Looks ok to me. Just some questions. ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (line 2122) <https://reviews.apache.org/r/40785/#comment168024> So now we always show these params? Do we have some default value for each paramter and skip those properties with the default value? ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (line 2126) <https://reviews.apache.org/r/40785/#comment168023> If this is the only statement in the block, can we merge two if statements into one? ql/src/test/results/clientpositive/show_create_table_delimited.q.out (line 36) <https://reviews.apache.org/r/40785/#comment168025> Now we expose those serde properties names. This is ok, right? - Jimmy Xiang On Nov. 29, 2015, 5:47 p.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40785/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2015, 5:47 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > More than one SerDe in Hive (e.g. LazySimpleSerDe, ColumnarSerDe) use the > DELIMITED properties, so "show create table" output with DELIMTED instead of > SERDE [WITH SERDEPROPERTIES] is not sufficient to be used to recreate the > same table. > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > 02cbd76 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a210b95 > ql/src/test/results/clientpositive/nullformat.q.out 6cfc2b8 > ql/src/test/results/clientpositive/nullformatCTAS.q.out 7adca68 > ql/src/test/results/clientpositive/show_create_table_delimited.q.out > 79f29de > > Diff: https://reviews.apache.org/r/40785/diff/ > > > Testing > ------- > > 1. Manual tests passed > 2. has been submitted for pre-commit build. > > > Thanks, > > Chaoyu Tang > >
