-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40628/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 7:49 p.m.)
Review request for hive.
Changes
-------
Thanks Aihua for review. I updated the patch based on our offline discussion
Bugs: HIVE-12505
https://issues.apache.org/jira/browse/HIVE-12505
Repository: hive-git
Description
-------
With HDFS Trash enabled but its encryption zone lower than Hive data directory,
insert overwrite command silently fails to trash the existing files during
overwrite, which could lead to unexpected incorrect results (more rows returned
than expected if the destination directory could not be cleaned completely).
This patch changes include:
1. catch trashing failure due to the probable lower Trash encryption zone, and
retry with force delete
2. if the destination directory could not be cleaned, throw exception instead
of swallowing it.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/FileUtils.java f943781
itests/src/test/resources/testconfiguration.properties 0c5140c
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 488d923
ql/src/test/queries/clientpositive/encryption_with_trash.q PRE-CREATION
ql/src/test/results/clientpositive/encrypted/encryption_with_trash.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/40628/diff/
Testing
-------
1. new unit tests passed
2. submitted for precommit test
Thanks,
Chaoyu Tang
