> On Dec. 4, 2015, 7:58 p.m., Mohit Sabharwal wrote: > > just passing through...
Sure thanks for the review. > On Dec. 4, 2015, 7:58 p.m., Mohit Sabharwal wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 705 > > <https://reviews.apache.org/r/40948/diff/1/?file=1153544#file1153544line705> > > > > Nit: add time unit to descreiption HiveConf has the time conf, so user can actually specify themselves via the suffix (like 's', 'ms', etc) > On Dec. 4, 2015, 7:58 p.m., Mohit Sabharwal wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 419 > > <https://reviews.apache.org/r/40948/diff/1/?file=1153548#file1153548line419> > > > > Seems like lot of INFO logging since it's every 5 minutes, no ? Make it > > DEBUG ? same for below.. That's true, but as its a new feature I wanted to enable logging by default so that user will know if this is causing an issue, and can disable it. - Szehon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40948/#review109014 ----------------------------------------------------------- On Dec. 4, 2015, 10:35 p.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40948/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 10:35 p.m.) > > > Review request for hive. > > > Bugs: HIVE-12499 > https://issues.apache.org/jira/browse/HIVE-12499 > > > Repository: hive-git > > > Description > ------- > > Add separate timer thread that polls for count of database, table, partition > entries to publish as metrics, the period is configurable. Delay in getting > exact number should be ok as this is for monitoring. > > Implemented for HBase and DB metastores. > > > Diffs > ----- > > > common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsConstant.java > 95e2bcf > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 4d881ba > common/src/test/org/apache/hadoop/hive/common/metrics/MetricsTestUtils.java > fd420f7 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreMetrics.java > f571c7c > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/hbase/TestHBaseMetastoreMetrics.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 00602e1 > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 1c0ab6d > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 5b36b03 > > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseReadWrite.java > 2fb3e8f > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java > 98e6c75 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 9a1d159 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 8dde0af > > Diff: https://reviews.apache.org/r/40948/diff/ > > > Testing > ------- > > Added unit tests for HBase and Db metastores. > > > Thanks, > > Szehon Ho > >
