----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42190/ -----------------------------------------------------------
Review request for hive and John Pullokkaran. Bugs: HIVE-12478 https://issues.apache.org/jira/browse/HIVE-12478 Repository: hive-git Description ------- Improve Hive/Calcite Trasitive Predicate inference Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 4825a617876374085b6fac1192ba1531ec916bce ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveDefaultRelMetadataProvider.java c0609d7773a1e49cc85a1d542caa16d74ac76efe ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveCost.java 3c5cac2f5b98925e8840466fa9d83cd28125ee03 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveCostModel.java d15d885d2348d666df069228a93d6c5f914c79df ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveUnion.java 8b57b3504c407b8a1e73d48ea240c4ec7558b327 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterMergeRule.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java de880ce26f1e172288f700c8566fbe71f42af115 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinPushTransitivePredicatesRule.java 703c8c6dbdfa281443cbcf7b08de2266697da8a9 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePreFilteringRule.java d37fc0e08d5e41b29539a990e6638385c1135eec ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java 50e139b4045ebac5a15bca05b1660dfeed4fe08c ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSyntheticSelectivityCost.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java f50f4d323220b1f90e33d5cf7daef9162998f5ec ql/src/test/results/clientpositive/annotate_stats_select.q.out b158d8567f6cc02d990d175e93996239aba0c5ed ql/src/test/results/clientpositive/auto_join12.q.out 8ef3664764d04f53f3685d8f66dc4a353776a488 ql/src/test/results/clientpositive/auto_join16.q.out c1da6d2968697d304311044d358f1af267dc6e60 ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out cfb95be72b32a354faeddc79dc52bc29c7593a2b ql/src/test/results/clientpositive/cast1.q.out 48a0c14031ef38dd5b4df7efa718a4d6ce04bc94 ql/src/test/results/clientpositive/cbo_SortUnionTransposeRule.q.out eef23891f3a155fac60628ee47afa08d77fa3a2e ql/src/test/results/clientpositive/cbo_const.q.out adc5232a67b2243dd5f09acaf1f7c49baea5daad ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out 1b2a2ab1af5992753c37d053942ecb2ebf775921 ql/src/test/results/clientpositive/constprog_partitioner.q.out 08c0aebafe1644a5adbec6a56879b39617bfbf69 ql/src/test/results/clientpositive/correlationoptimizer13.q.out 61b7bcb675a80dc3267365c65545e107ecbe12d2 ql/src/test/results/clientpositive/correlationoptimizer8.q.out 368a1147d404ae9aab18a64618abf8ed7b3f7189 ql/src/test/results/clientpositive/correlationoptimizer9.q.out 104a97afbb6657255a027ff6d51101f6963c2358 ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out 743865e073e1768f7f6234fde35ad2e56d8babe9 ql/src/test/results/clientpositive/filter_cond_pushdown.q.out 5e0edbc9efb442467c4998021ac1ecfb9d07579d ql/src/test/results/clientpositive/filter_join_breaktask.q.out 13d17aafa8fc15c980ffa7366a4ca8c7abe8fd50 ql/src/test/results/clientpositive/groupby_position.q.out c2566f2ad5d426db8814b7ca85207807f4a5afc7 ql/src/test/results/clientpositive/groupby_ppd.q.out d17c4b6d9e88d49d64b9725be1e51ca258ad1167 ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 9c45602a3898cbef90ac13c8f65cca54cb9a7bd8 ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out ad263bc4cb9885e9d06c2ec4716a2cce56d11065 ql/src/test/results/clientpositive/index_auto_mult_tables.q.out 8c71925fbc5352f42abb280fc45a1d5a5713ebad ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out b3e698927689dad5229165189779300cb8beca9b ql/src/test/results/clientpositive/input_part1.q.out c5c46af6a69ffb8613fd7d3898ca32d3c6b802f4 ql/src/test/results/clientpositive/input_part5.q.out c6ae2fd58d7d41e4b4c0f764de3e28484917cd97 ql/src/test/results/clientpositive/input_part6.q.out c01d8afb6230440103ed8c1ecb38aea9eaabc832 ql/src/test/results/clientpositive/join12.q.out 8217c86d0e41c78b8bf4ed120b30a85204fa9915 ql/src/test/results/clientpositive/join16.q.out 244eb46dc0ae3b61ed932f043a98bb64295776a1 ql/src/test/results/clientpositive/join34.q.out 795dd3a39c989301efdb900f90a51d725e9dad6b ql/src/test/results/clientpositive/join35.q.out c5231543e3e954c72274dc3fb9e3f0e83fce5516 ql/src/test/results/clientpositive/join42.q.out 6e09e38102129edb7246b0a027c86ba1deed066c ql/src/test/results/clientpositive/limit_join_transpose.q.out 759aebb5d2ec59267535e12cb20f4a812e8a80d0 ql/src/test/results/clientpositive/lineage2.q.out a189f82a3d29cd3b1e21a43afc85ef14fd74c79e ql/src/test/results/clientpositive/lineage3.q.out f1162a213eea285a5d166731e0ce7e407f4106a7 ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 9c406a720398c14f7df09045a07f0cad5afa5437 ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 1fb76d8a8f32e0d63eba743d6007ffc7691b9b30 ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out d2c11d7644570217532f9b366926d8cc94a03e6a ql/src/test/results/clientpositive/llap/tez_dynpart_hashjoin_1.q.out b459692b443a1686def6615e9e9bcce5922335c3 ql/src/test/results/clientpositive/llap/tez_vector_dynpart_hashjoin_1.q.out 6a57f1fd82ef3e3cf681138383534e7fea1c07df ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out 63121a9e5b043e2c27fe08ee54e6fe01e2dd6cae ql/src/test/results/clientpositive/louter_join_ppr.q.out 1f685ae7ae5989ab14f045fcafa99dabf54bc1e1 ql/src/test/results/clientpositive/mergejoin.q.out acf816ebc2db9df7f2878375dea3c403fb513c08 ql/src/test/results/clientpositive/mergejoins.q.out 901041083f3182497361b8f27ed77c093e7ce237 ql/src/test/results/clientpositive/mergejoins_mixed.q.out 10f37f9fe34d79987333e3f8bb01166304fe5894 ql/src/test/results/clientpositive/multiMapJoin1.q.out e2efec0295e2d15aa1497b848eb6eb8838617b7f ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 90032fe53d37163e09fbf2b1bf7dac0e55b80b18 ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out 7c5be6dbe636f6cfcf8f4a3563d2b204d3cb2b46 ql/src/test/results/clientpositive/partition_multilevels.q.out 699c1790314f0ea3bff2eae4aa6f3231eddead51 ql/src/test/results/clientpositive/perf/query31.q.out 909d64cef12a9492c5d24ef5876609a77423d2d5 ql/src/test/results/clientpositive/perf/query39.q.out 9f3e650943c1d7ab04fc521509ca9372e4105a25 ql/src/test/results/clientpositive/perf/query40.q.out b2d6262d96b7dc1c25748a758af61988b39d7c45 ql/src/test/results/clientpositive/perf/query42.q.out 9ede45d24587228328671a40e9b3f9ca43e2a550 ql/src/test/results/clientpositive/perf/query52.q.out 7e7224ba54b49a68040a536adca665a8f510bdd7 ql/src/test/results/clientpositive/perf/query58.q.out c2f71892ee7ceb68449c6c4f13754052041de106 ql/src/test/results/clientpositive/perf/query64.q.out 9331673a663e9b31bfb00b443c4ae282ffe67e56 ql/src/test/results/clientpositive/perf/query66.q.out a25664e73afb1088e05ec3912dab253720bc4af4 ql/src/test/results/clientpositive/perf/query72.q.out bb56f0d695ede28d37b210fc1c6293444038154e ql/src/test/results/clientpositive/perf/query75.q.out f3f9827a532b445e59642cbf9d169dc4147e03d2 ql/src/test/results/clientpositive/perf/query80.q.out 37cb542f008b21b26e2bdd03aac7144b7352893b ql/src/test/results/clientpositive/perf/query85.q.out 54061ced073090cec35111081f21ac510d0bde92 ql/src/test/results/clientpositive/perf/query94.q.out 0357835f7f5e565f560e73506b10345c0fe089ff ql/src/test/results/clientpositive/pointlookup2.q.out 1d7efe8d86c067b2000be3a740658ba1d5e8b754 ql/src/test/results/clientpositive/ppd_join3.q.out 0000db129c9428e34935397ab5c51f010987eca3 ql/src/test/results/clientpositive/ppd_outer_join2.q.out 82e4ef5332e6d178ab19a544179f415ffd9efede ql/src/test/results/clientpositive/ppd_outer_join3.q.out de82fe0ee9d7480c693b87f22e4f9a82b509e9a4 ql/src/test/results/clientpositive/ppd_outer_join4.q.out 289798c5bc0113ea4864e2c287001805a8fc1ea9 ql/src/test/results/clientpositive/ppd_outer_join5.q.out 35fec7a46606b0489d9c4e9c472a26607b17a177 ql/src/test/results/clientpositive/ppd_udf_case.q.out 2b407a63d8b51cfedc020459240150b97044ffc3 ql/src/test/results/clientpositive/ppd_union_view.q.out ba51cbd4db0021b30b3592f740b895b0e20aa59a ql/src/test/results/clientpositive/quotedid_basic.q.out 3c81e0bccce92d489d4f2eec874826a1d232c7be ql/src/test/results/clientpositive/quotedid_partition.q.out a83c62b1826786f5213c8556bd275e4bd545fb6a ql/src/test/results/clientpositive/router_join_ppr.q.out b486f21385f45d12c15013c848d724202e97d014 ql/src/test/results/clientpositive/skewjoin.q.out 4e98dfd9e7aedd8cffbe1aee64c03d62741763d7 ql/src/test/results/clientpositive/spark/auto_join12.q.out 158e53511f43bd12fc006bd595c4dab48dc1cf94 ql/src/test/results/clientpositive/spark/auto_join16.q.out ba6336aaa5213f0dcd292bd1fb07c9582fb1c6fd ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out 57a89d67b56cc36dda8b42f21481e9363cff297a ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_7.q.out 0b64a8735a6e9a668650db8907abce38c31ab70e ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out 6e595ff4b19d188b041394aff5df6d93614fe813 ql/src/test/results/clientpositive/spark/filter_join_breaktask.q.out 74742b2f8887baa23023a61a8b7497eafce0d967 ql/src/test/results/clientpositive/spark/groupby_position.q.out 415703f638ede1e113fd3f7864f2f8688302c38d ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 0b54b85ea01b464a931c1761583b4eed63558634 ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 0b8ec5439d5d1e78b95dda349ddeaf58815e021f ql/src/test/results/clientpositive/spark/join12.q.out 2ad0a43853e832fe7d16678d38e6b5b1f43f467f ql/src/test/results/clientpositive/spark/join16.q.out 2496ec2904272923c346d746f6150a34ffee63be ql/src/test/results/clientpositive/spark/join34.q.out 0f2c413dd59f8926bf0c37706d064a313d090d97 ql/src/test/results/clientpositive/spark/join35.q.out 0519689c9a78ef75aabfcf663d95a96033ab6ae0 ql/src/test/results/clientpositive/spark/louter_join_ppr.q.out c22158ca7130c3839ea0133fe84d92a3f04e791b ql/src/test/results/clientpositive/spark/mergejoins.q.out e6872400b45cadc969ef897cf42c38dd23b9581f ql/src/test/results/clientpositive/spark/mergejoins_mixed.q.out 42ffebfde50472f1aec060c33037fe851921e88c ql/src/test/results/clientpositive/spark/ppd_join3.q.out c78d4cb4580d17946375f6ee5b6c447741d7c6f4 ql/src/test/results/clientpositive/spark/ppd_outer_join2.q.out 869596140ea9878c41eb3d44643f1f5c0e682dc3 ql/src/test/results/clientpositive/spark/ppd_outer_join3.q.out 4a8c58cfaa3257b69398457c43e16cbfe630bb15 ql/src/test/results/clientpositive/spark/ppd_outer_join4.q.out 8d0830892ab997e489306ec2698e1c6fdf61996f ql/src/test/results/clientpositive/spark/ppd_outer_join5.q.out 8e398580ac526c0acbd642bc91579fcea0d9b428 ql/src/test/results/clientpositive/spark/router_join_ppr.q.out 620e5d200c05d1e9e884160170128d3f61fa231d ql/src/test/results/clientpositive/spark/skewjoin.q.out b2460460da36e856655ca12706678378b976f059 ql/src/test/results/clientpositive/spark/subquery_exists.q.out 5f41ac7aeaa5425004a4cd56638f0961a5a78a7e ql/src/test/results/clientpositive/spark/subquery_in.q.out 1d813f8ae53e6cccde25e864d168380568e02e7a ql/src/test/results/clientpositive/spark/union_remove_25.q.out 91aa1f2758ef402ddc88f31936abbd0a09315333 ql/src/test/results/clientpositive/spark/union_view.q.out 492f71b10b9e98cd9235fad4b40850b2aa2d9730 ql/src/test/results/clientpositive/spark/vector_mapjoin_reduce.q.out 296c256d09703a073a41a36dc96b526e78afb715 ql/src/test/results/clientpositive/subquery_exists.q.out f3a270589b7b50dd7ef2ec53d1bac7ae88f7f245 ql/src/test/results/clientpositive/subquery_in.q.out a374dc0f84aa78dcf099d8733b42f94e6cea7863 ql/src/test/results/clientpositive/subquery_in_having.q.out 87c5a623dfa44e903710794634e459dc66bbd86a ql/src/test/results/clientpositive/subquery_notexists.q.out 215d855f20d09b9e92da7a753cbce90760a73f0c ql/src/test/results/clientpositive/subquery_notexists_having.q.out 637fc62941e6f8b4852c4b1a4d51d6b2517912a3 ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out e34a401ca41faae0f25e7f398ac5c078f8f34df8 ql/src/test/results/clientpositive/subquery_views.q.out 76e53d3be56f3f8c2422317585d441cd14665294 ql/src/test/results/clientpositive/tez/bucket_map_join_tez1.q.out 4703cec3fdcbb79bbc4b0365b97600e760ac2748 ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 58ab2c08554f4b2b4d06e79de22845445fc3c0e5 ql/src/test/results/clientpositive/tez/explainuser_1.q.out 8c78fd9d7f23f5272d88e83378485c83605c5b5a ql/src/test/results/clientpositive/tez/filter_join_breaktask.q.out bb0c6f1b2d3e09fea294457f609194505218dd6b ql/src/test/results/clientpositive/tez/mergejoin.q.out 4b2d9635fe602fa6aa03d20d32bb57770a92ac39 ql/src/test/results/clientpositive/tez/skewjoin.q.out fc084cc5b8c798ceb6bfc84ad1b29ca5d3c91f48 ql/src/test/results/clientpositive/tez/subquery_exists.q.out 5121a144c1d6c2c28890cd742e59d3c1bb868c9a ql/src/test/results/clientpositive/tez/subquery_in.q.out a4887e4e69fd8d2734583586a67daf1bfeacf8ac ql/src/test/results/clientpositive/tez/tez_dynpart_hashjoin_1.q.out e3131d5071c891b35340d040efb44ab3ea10a46c ql/src/test/results/clientpositive/tez/tez_smb_empty.q.out 8c9ab2eda3b88362f38bf795e001dfc72ca52a73 ql/src/test/results/clientpositive/tez/tez_vector_dynpart_hashjoin_1.q.out 3711a10f425ba54153cf4fbca02ba86a09b401f6 ql/src/test/results/clientpositive/tez/vector_decimal_round.q.out 5bc04d7e02fa7b70050116ba8f1d062877691ae0 ql/src/test/results/clientpositive/tez/vector_mapjoin_reduce.q.out 7eb28f8e2a5af32075e2fa1a1ad89af092a36e90 ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out cda76db1f9966a0b1969381faa3ad035568edb84 ql/src/test/results/clientpositive/udf1.q.out b3b694b8794ac6eb3fe6d0bbc29e51e7602f16e8 ql/src/test/results/clientpositive/udf_10_trims.q.out 3a5303adfe8450adff1eeb7f32f83b1150979c09 ql/src/test/results/clientpositive/udf_folder_constants.q.out ef07420325dd2d99322f4fc150951798dcdeafaa ql/src/test/results/clientpositive/udf_unix_timestamp.q.out c64379d3e501793620a0b3dd010a2ada4912a118 ql/src/test/results/clientpositive/union_remove_25.q.out d82fcfc726428347159d6186d9c7fdce6034980e ql/src/test/results/clientpositive/union_view.q.out 1d93159e2b2c1ede1c090fb82db1928872fd2c61 ql/src/test/results/clientpositive/vector_decimal_round.q.out ec6226ea74ece7b4129428dcf98d6f7af8f55e6e ql/src/test/results/clientpositive/vector_mapjoin_reduce.q.out dd40f282c7392f4eb8ef674cb5f6629d41eacf01 Diff: https://reviews.apache.org/r/42190/diff/ Testing ------- Thanks, Jesús Camacho Rodríguez