----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/#review116920 -----------------------------------------------------------
service/src/java/org/apache/hive/service/cli/CLIService.java (line 207) <https://reviews.apache.org/r/41928/#comment178004> Can you rename method to createSessionWithHandle as suggested? service/src/java/org/apache/hive/service/cli/session/SessionManager.java (line 283) <https://reviews.apache.org/r/41928/#comment178006> Can we make it package private? service/src/java/org/apache/hive/service/cli/session/SessionManager.java (line 356) <https://reviews.apache.org/r/41928/#comment178005> Is this method required? Can CLIService directly call createSession ? - Amareshwari Sriramadasu On Jan. 28, 2016, 7:18 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41928/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2016, 7:18 a.m.) > > > Review request for hive. > > > Bugs: HIVE-12777 > https://issues.apache.org/jira/browse/HIVE-12777 > > > Repository: hive-git > > > Description > ------- > > Extensions using Hive session handles should be able to restore the hive > session from the handle. > > Apache Lens depends on a fork of hive and that fork has such a capability. > > Relevant commit: > https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be > > > Diffs > ----- > > service/src/java/org/apache/hive/service/cli/CLIService.java > 0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 > service/src/java/org/apache/hive/service/cli/SessionHandle.java > 4e4f0211de09408168c8da669626fb49f3db364c > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > 3c5700bd114f6b792df10df23e57dad9b9e689f6 > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java > c56d97afc969ea57810e9b3222b20e086e847d67 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > de18f1d93502704e7a8fbb8d31d93bd770c4d232 > service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/41928/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
