> On Jan. 15, 2016, 11:49 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdDistribution.java, > > line 40 > > <https://reviews.apache.org/r/42281/diff/2/?file=1198059#file1198059line40> > > > > Why is this removed?
The reason is that it is redundant. - pengcheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42281/#review114798 ----------------------------------------------------------- On Jan. 15, 2016, 7:10 a.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42281/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2016, 7:10 a.m.) > > > Review request for hive and John Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > HIVE-12839 > > > Diffs > ----- > > pom.xml 802d3d4 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java > 1c15012 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelFactories.java > eeec44e > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveAlgorithmsUtil.java > 6840418 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveDefaultCostModel.java > 6669d32 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveOnTezCostModel.java > 61a3a64 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveRelMdCost.java > 90f6a7e > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java > aae57e6 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveFilter.java > 2f8cc7d > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveJoin.java > c323564 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java > c5376bf > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveSemiJoin.java > 4fac13e > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableScan.java > 5788805 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java > 070c7ea > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveExpandDistinctAggregatesRule.java > 7d7631b > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinPushTransitivePredicatesRule.java > 07928d8 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java > 50e139b > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortJoinReduceRule.java > 0af60e8 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortRemoveRule.java > 618c717 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortUnionReduceRule.java > 0ec8bf1 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/FilterSelectivityEstimator.java > c04060f > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdCollation.java > 84fa518 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdDistinctRowCount.java > 1220401 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdDistribution.java > b83f240 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdMemory.java > bea5943 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdParallelism.java > 2f51d3b > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdPredicates.java > b7244fd > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java > caf8978 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSelectivity.java > a0eb83d > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSize.java > 3224039 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdUniqueKeys.java > 7c22c33 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java > c79b1be > ql/src/test/results/clientpositive/auto_join12.q.out 27858e7 > ql/src/test/results/clientpositive/auto_join13.q.out fa03d2c > ql/src/test/results/clientpositive/auto_join_without_localtask.q.out > 1521a71 > ql/src/test/results/clientpositive/cbo_const.q.out d6682ca > ql/src/test/results/clientpositive/correlationoptimizer10.q.out e210c7f > ql/src/test/results/clientpositive/filter_cond_pushdown.q.out 1c3a5ab > ql/src/test/results/clientpositive/infer_bucket_sort.q.out 182dd3a > > ql/src/test/results/clientpositive/infer_bucket_sort_reducers_power_two.q.out > 1e4db29 > ql/src/test/results/clientpositive/join28.q.out 9aadd28 > ql/src/test/results/clientpositive/join32.q.out 5cb124b > ql/src/test/results/clientpositive/join32_lessSize.q.out 544e814 > ql/src/test/results/clientpositive/join33.q.out 5cb124b > ql/src/test/results/clientpositive/join_parse.q.out ab657cc > ql/src/test/results/clientpositive/limit_join_transpose.q.out 759aebb > ql/src/test/results/clientpositive/llap/tez_join_hash.q.out adacc33 > ql/src/test/results/clientpositive/mapjoin_mapjoin.q.out 6193580 > ql/src/test/results/clientpositive/mapjoin_subquery.q.out cb6d92d > ql/src/test/results/clientpositive/mergejoins.q.out eb3ad8a > ql/src/test/results/clientpositive/ppd_join3.q.out af627bf > ql/src/test/results/clientpositive/ppd_outer_join4.q.out 4d89aee > ql/src/test/results/clientpositive/spark/auto_join_without_localtask.q.out > 68e51a7 > ql/src/test/results/clientpositive/spark/join28.q.out 548a806 > ql/src/test/results/clientpositive/spark/join32.q.out 3771217 > ql/src/test/results/clientpositive/spark/join32_lessSize.q.out c4ac2dd > ql/src/test/results/clientpositive/spark/join33.q.out 3771217 > ql/src/test/results/clientpositive/spark/mapjoin_subquery.q.out b348472 > ql/src/test/results/clientpositive/spark/mergejoins.q.out 3f7ec0e > ql/src/test/results/clientpositive/spark/ppd_join3.q.out 7ce8f9e > ql/src/test/results/clientpositive/spark/ppd_outer_join4.q.out 87580e9 > ql/src/test/results/clientpositive/tez/explainuser_2.q.out d8eb6c8 > ql/src/test/results/clientpositive/tez/tez_join_hash.q.out 0ee1917 > ql/src/test/results/clientpositive/vector_outer_join3.q.out 3345247 > > Diff: https://reviews.apache.org/r/42281/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
