----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43176/#review118398 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java (line 135) <https://reviews.apache.org/r/43176/#comment179626> I think the existance of a file/dir can be checked by calling FS.exists(). I usually avoid depending on exception to do something useful other than handling exception itself. However, it's up to you. ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java (line 160) <https://reviews.apache.org/r/43176/#comment179627> it seems fs didn't get closed in all paths. However, I understand that the problem was there before. - Xuefu Zhang On Feb. 4, 2016, 4:07 a.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43176/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2016, 4:07 a.m.) > > > Review request for hive, Ashutosh Chauhan, Szehon Ho, and Xuefu Zhang. > > > Bugs: HIVE-12965 > https://issues.apache.org/jira/browse/HIVE-12965 > > > Repository: hive-git > > > Description > ------- > > In Hive, "insert overwrite local directory" first deletes the overwritten > directory if exists, recreate a new one, then copy the files from src > directory to the new local directory. This process sometimes changes the > permissions of the to-be-overwritten local directory, therefore causing some > applications no more to be able to access its content. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java e9cd450 > > Diff: https://reviews.apache.org/r/43176/diff/ > > > Testing > ------- > > Manual tests > Precommit tests > > > Thanks, > > Chaoyu Tang > >
