> On March 1, 2016, 8:25 a.m., Amareshwari Sriramadasu wrote: > > service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java, > > line 61 > > <https://reviews.apache.org/r/44201/diff/1/?file=1275009#file1275009line61> > > > > Can you update test to call new method introduced? > > Rajat Khandelwal wrote: > Updated. Test is also passing
Can you update by calling close Transport() as well ? - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44201/#review121407 ----------------------------------------------------------- On March 2, 2016, 6:07 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44201/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 6:07 a.m.) > > > Review request for hive. > > > Bugs: HIVE-13188 > https://issues.apache.org/jira/browse/HIVE-13188 > > > Repository: hive-git > > > Description > ------- > > RetryingThriftCLIClient opens a TTransport and leaves it open. there should > be a way to close that. > > > Diffs > ----- > > > service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java > a81c600236e6e0f53a484806e559303279244616 > > service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java > 3798053a4a2e2b26b97b5accf96d73b58c89fb6e > > Diff: https://reviews.apache.org/r/44201/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
