-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44146/
-----------------------------------------------------------
(Updated March 3, 2016, 1:48 p.m.)
Review request for hive.
Bugs: HIVE-13179
https://issues.apache.org/jira/browse/HIVE-13179
Repository: hive-git
Description
-------
Right now if I want to create an ldap auth provider, I have to create a
hive-site.xml, set endpoints and other relevant properties there, then
instantiate `LdapAuthenticationProviderImpl`, since inside the constructor, a
new HiveConf is constructed.
A better and more reusable design would be to ask for the conf in the
constructor itself. That will allow an external user to create a HiveConf, set
all relevant properties and instantiate `LdapAuthenticationProviderImpl` with
that conf.
Diffs (updated)
-----
service/src/java/org/apache/hive/service/auth/AuthenticationProviderFactory.java
4b95503eb19cf862fb6efa614c9746b477337158
service/src/java/org/apache/hive/service/auth/CustomAuthenticationProviderImpl.java
3dc0aa86e2d4acc9604e27dabb8f683d4cd0705d
service/src/java/org/apache/hive/service/auth/LdapAuthenticationProviderImpl.java
1d4aba2cc37930d87b620815fb317c1977f6e901
service/src/java/org/apache/hive/service/auth/PamAuthenticationProviderImpl.java
fd58081653af1a846394eddd513d94751e0129e2
service/src/test/org/apache/hive/service/auth/TestLdapAtnProviderWithMiniDS.java
e5cee37ac72001086323c94392274fb86f4307ef
service/src/test/org/apache/hive/service/auth/TestLdapAuthenticationProviderImpl.java
5e91a0eb8a1bfc8a8d6e6774b195de9731035bdd
Diff: https://reviews.apache.org/r/44146/diff/
Testing
-------
Thanks,
Rajat Khandelwal
