-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44172/
-----------------------------------------------------------

(Updated March 7, 2016, 12:19 p.m.)


Review request for hive and Alan Gates.


Bugs: HIVE-11483
    https://issues.apache.org/jira/browse/HIVE-11483


Repository: hive-git


Description
-------

We have seen some queries in production where some of the literals passed in 
the query have control characters, which result in exception when query string 
is set in the job xml.

Proposing a solution to encode the query string in configuration and provide 
getters decoded string.

Here is a commit in a forked repo : 
https://github.com/InMobi/hive/commit/2faf5761191fa3103a0d779fde584d494ed75bf5

Suggestions are welcome on the solution.


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
2723dadd76418f23b6e6358d21304e3312ef1cbd 
  common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java 
365d5005d2a1f240b12bb4e9f9a920b3db4d32ba 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 
32531465cba95de6caa1bd292d489c1582efb942 
  ql/src/java/org/apache/hadoop/hive/ql/exec/errors/TaskLogProcessor.java 
68123d45c335e833984d3547607dc3ee7d8fd870 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 
b184b4e554cf3f7a61932195b9b840cf13f3594b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java 
473dbd61bf538fe08953dcf7994d5821f6bdbacc 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 
70b2bc0cc15cd862cdb1adba0690d0530681ebde 
  ql/src/test/org/apache/hadoop/hive/ql/exec/errors/TestTaskLogProcessor.java 
67a86a60949a6b70f71593470a6d0ef8c265ee04 
  ql/src/test/org/apache/hadoop/hive/ql/hooks/TestHooks.java 
8d27762522f0ac5f59696e019ec52a25e77318db 

Diff: https://reviews.apache.org/r/44172/diff/


Testing
-------


Thanks,

Rajat Khandelwal

Reply via email to