> On March 22, 2016, 5:09 a.m., Gopal V wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java, > > line 844 > > <https://reviews.apache.org/r/45062/diff/1/?file=1307057#file1307057line844> > > > > is Data ever non-null here?
Yes, in EncodedReaderImpl // 2.5. Remember the bad estimates for future reference. if (badEstimates != null && !badEstimates.isEmpty()) { // Relies on the fact that cache does not actually store these. DiskRange[] cacheKeys = badEstimates.toArray(new DiskRange[badEstimates.size()]); long[] result = cacheWrapper.putFileData(fileKey, cacheKeys, null, baseOffset); assert result == null; // We don't expect conflicts from bad estimates. } - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45062/#review124732 ----------------------------------------------------------- On March 18, 2016, 11:18 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45062/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 11:18 p.m.) > > > Review request for hive, Gopal V and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 98c6372 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/EvictionDispatcher.java > bae571e > > llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapOptionsProcessor.java > c292b37 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java > dbee823 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > eb251a8 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcFileEstimateErrors.java > PRE-CREATION > > llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcMetadataCache.java > e970137 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestOrcMetadataCache.java > 901e58a > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java > 29b51ec > > storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java > ddba889 > > Diff: https://reviews.apache.org/r/45062/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >