----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45406/#review128275 -----------------------------------------------------------
metastore/if/hive_metastore.thrift (line 1209) <https://reviews.apache.org/r/45406/#comment191702> I am not sure if this is needed. metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql (line 1) <https://reviews.apache.org/r/45406/#comment191710> Do you need TBL_ID? Since you need a join with TBLS anyway and CD_ID is unique, I don't think its useful to store TBL_ID here. metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql (line 2) <https://reviews.apache.org/r/45406/#comment191713> Any reason for index on constraint name, position? I think on CD_ID it makes more sense. metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql (line 996) <https://reviews.apache.org/r/45406/#comment191714> Its better to just inline those statements. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 6141) <https://reviews.apache.org/r/45406/#comment191715> I don't think there is need for this. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 6170) <https://reviews.apache.org/r/45406/#comment191716> No need for this. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 6173) <https://reviews.apache.org/r/45406/#comment191717> Neither for this. - Ashutosh Chauhan On April 11, 2016, 5:45 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45406/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 5:45 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > Metastore Changes : API calls for retrieving primary keys and foreign keys > information > > > Diffs > ----- > > metastore/if/hive_metastore.thrift 6a55962 > metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION > metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6 > metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c > metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662 > metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2 > metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209 > metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636 > metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be > metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08 > metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37 > metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql > 6172407 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > c9fadad > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > cdd12ab > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 39cf927 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 06e9f78 > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > ac293b9 > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757 > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java > a73dbeb > metastore/src/model/package.jdo 7385a13 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 94ca835 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > b108f95 > service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote 9a2322f > > Diff: https://reviews.apache.org/r/45406/diff/ > > > Testing > ------- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
