> On April 6, 2016, 10:37 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g, lines 321-328 > > <https://reviews.apache.org/r/45274/diff/1/?file=1313165#file1313165line321> > > > > We should not reserve these KWs, as this may cause backward > > compatibility issue.
According to http://www.postgresql.org/docs/9.2/static/sql-keywords-appendix.html, primary, foreign, REFERENCES, CONSTRAINT are a reserved key word. So we can reserve all of them and add them under "sql11ReservedKeywordsUsedAsIdentifier" in IdenfiersParser.g for backward compatibility. For the rest of them, KEY, NOVALIDATE, RELY NORELY, we should put them under "nonReserved" in IdenfiersParser.g - pengcheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45274/#review127479 ----------------------------------------------------------- On April 23, 2016, 8:20 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45274/ > ----------------------------------------------------------- > > (Updated April 23, 2016, 8:20 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > Support primary keys/foreign keys constraint as part of create table command > in Hive > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > ae6f084 > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java f091f67 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java b26f09d > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4c9acce > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > 19342a8 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g dd997f0 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 50c53db > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g a192fa7 > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > 549d24f > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 005b53f > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 03b4d8b > ql/src/test/queries/clientnegative/create_with_constraints_duplicate_name.q > PRE-CREATION > ql/src/test/queries/clientnegative/create_with_constraints_enable.q > PRE-CREATION > ql/src/test/queries/clientnegative/create_with_constraints_validate.q > PRE-CREATION > ql/src/test/queries/clientpositive/create_with_constraints.q PRE-CREATION > > ql/src/test/results/clientnegative/create_with_constraints_duplicate_name.q.out > PRE-CREATION > ql/src/test/results/clientnegative/create_with_constraints_enable.q.out > PRE-CREATION > ql/src/test/results/clientnegative/create_with_constraints_validate.q.out > PRE-CREATION > ql/src/test/results/clientpositive/create_with_constraints.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/45274/diff/ > > > Testing > ------- > > Local testing done > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
