----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46597/#review130369 -----------------------------------------------------------
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/ContainerRunner.java (line 32) <https://reviews.apache.org/r/46597/#comment194096> Throw something other than IOException, which typically indicates a network communicationn error in the Hadoop world. llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java (line 283) <https://reviews.apache.org/r/46597/#comment194108> Could you please add a TODO/jira to get rid of this, and get this either from the request itself, or from QueryTracker. The scheduler should not be accesssed to get information like this. llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java (line 120) <https://reviews.apache.org/r/46597/#comment194099> Accept the appIdentifier directly, and have the containerId parsed in main / MiniLlap. llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java (line 150) <https://reviews.apache.org/r/46597/#comment194100> MiniLlap can set this up explicitly. When running outside of YARN - this will end up having to be setup as an environment variable. Instead of going the UUID route, I think we should set this up in MiniLLAP, and fail under regular use - instead of generating a random string which could lead to all kinds of crazy behaviour in a multi-node setup. llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapTokenChecker.java (line 87) <https://reviews.apache.org/r/46597/#comment194103> Think we should add some simple unit tests for this class. llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java (line 196) <https://reviews.apache.org/r/46597/#comment194095> A containerId can be constructed and sent in here to avoid the UUID random inside the cluster. MiniLLAP supports multiple instances, which will otherwise end up with different UUIDs. - Siddharth Seth On April 23, 2016, 2:08 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46597/ > ----------------------------------------------------------- > > (Updated April 23, 2016, 2:08 a.m.) > > > Review request for hive and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > > llap-common/src/gen/protobuf/gen-java/org/apache/hadoop/hive/llap/daemon/rpc/LlapDaemonProtocolProtos.java > 4ab7b32 > llap-common/src/java/org/apache/hadoop/hive/llap/DaemonId.java PRE-CREATION > > llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapTokenIdentifier.java > 23980d0 > > llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapTokenProvider.java > 2e99a28 > llap-common/src/protobuf/LlapDaemonProtocol.proto 944c96c > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/ContainerRunner.java > fc29371 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java > e80fb15 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java > a0250cb > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java > e99e689 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapTokenChecker.java > PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java > 64c2b58 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java > 14657e6 > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/Scheduler.java > 26c8e55 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java > 57dd828 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java > 76ba225 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java > 8c7a539 > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java > 610f266 > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java > 4d05c35 > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java > a65bf5c > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java 8aca779 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 3ea5ef9 > > Diff: https://reviews.apache.org/r/46597/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
