Jason Dere created HIVE-13650:
---------------------------------

             Summary: LLAP: Other todo items in LlapTaskUmbilicalExternalClient
                 Key: HIVE-13650
                 URL: https://issues.apache.org/jira/browse/HIVE-13650
             Project: Hive
          Issue Type: Sub-task
          Components: llap
            Reporter: Jason Dere


Other TODOs from LlapTaskUmbilicalExternalClient:

- From submitWork():
{code}
//    // TODO Also send out information saying that the fragment is finishable 
- if that is not already included in the main fragment.
//    // This entire call is only required if we're doing more than scans. 
MRInput has no dependencies and is always finishable
//    QueryIdentifierProto queryIdentifier = QueryIdentifierProto
//        .newBuilder()
//        
.setAppIdentifier(submitWorkRequestProto.getApplicationIdString()).setDagIdentifier(submitWorkRequestProto.getFragmentSpec().getDagId())
//        .build();
//    LlapDaemonProtocolProtos.SourceStateUpdatedRequestProto 
sourceStateUpdatedRequest =
//        
LlapDaemonProtocolProtos.SourceStateUpdatedRequestProto.newBuilder().setQueryIdentifier(queryIdentifier).setState(
//            LlapDaemonProtocolProtos.SourceStateProto.S_SUCCEEDED).
//            setSrcName(TODO)
//    
communicator.sendSourceStateUpdate(LlapDaemonProtocolProtos.SourceStateUpdatedRequestProto.newBuilder().setQueryIdentifier(submitWorkRequestProto.getFragmentSpec().getFragmentIdentifierString()).set);
{code}

- HeartbeatCheckTask.run(): If the heartbeat times out and we abandon the LLAP 
task, we may want to notify the LLAP daemon that we are no longer interested in 
this task.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to