> On April 30, 2016, 7:06 a.m., Siddharth Seth wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java, > > line 192 > > <https://reviews.apache.org/r/46754/diff/1/?file=1364102#file1364102line192> > > > > If we're using a common UGI across all tasks - which is the kerberos > > UGI - I don't think we should add these credentials. That'll end up leaking > > credentials across tasks - and in general is not required assuming SQL > > standard auth. > > For non-sql standard auth - we could continue with credentials only.
What about HBase and other systems? using the keytab would mean giving that user access or not having it at all. I'll add the clone of UGI... - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46754/#review131247 ----------------------------------------------------------- On April 27, 2016, 11:01 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46754/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 11:01 p.m.) > > > Review request for hive and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/UgiFactory.java PRE-CREATION > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5360ed4 > > llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstanceSet.java > 73f94f3 > > llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java > 6af30d4 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java > e80fb15 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java > 33b41e8 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java > e99e689 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java > 2a60123 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java > 6a72b4c > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ColumnVectorProducer.java > b3b571d > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java > 76ba225 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java > 8c7a539 > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java > 24f4442 > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/comparator/TestFirstInFirstOutComparator.java > 08ee769 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java 8aca779 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordProcessor.java > 0584ad8 > > Diff: https://reviews.apache.org/r/46754/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
