----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46929/#review131518 -----------------------------------------------------------
hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java (line 93) <https://reviews.apache.org/r/46929/#comment195521> Instead of hard-coding port number. This should be dynamically determined, e.g., using MetaStoreUtils.findFreePort() hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java (line 117) <https://reviews.apache.org/r/46929/#comment195522> I don't follow this. If it throws exception in what circumstance you will be able to connect after 1 sec? hcatalog/webhcat/java-client/src/test/java/org/apache/hive/hcatalog/api/TestHCatClient.java (line 87) <https://reviews.apache.org/r/46929/#comment195523> Need to determine this dynamically. hcatalog/webhcat/java-client/src/test/java/org/apache/hive/hcatalog/api/TestHCatClient.java (line 120) <https://reviews.apache.org/r/46929/#comment195524> There is already a utility method for this. See: MetastoreUtils::startMetaStore() metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreGetMetaConf.java (line 46) <https://reviews.apache.org/r/46929/#comment195525> Need to determine this dynamically. metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreGetMetaConf.java (line 85) <https://reviews.apache.org/r/46929/#comment195526> Please use MetastoreUtils::startMetaStore() metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java (line 54) <https://reviews.apache.org/r/46929/#comment195527> Need to determine this dynamically. ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveRemote.java (line 57) <https://reviews.apache.org/r/46929/#comment195528> Use MetastoreUtils::startMetaStore() - Ashutosh Chauhan On May 3, 2016, 8:33 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46929/ > ----------------------------------------------------------- > > (Updated May 3, 2016, 8:33 a.m.) > > > Review request for hive. > > > Bugs: HIVE-13676 > https://issues.apache.org/jira/browse/HIVE-13676 > > > Repository: hive-git > > > Description > ------- > > In 5-6 test classes, metastore is required to be up for tests to run. The > metastore is started in setup Phase asynchronously. But there's no logic to > wait till the metastore comes up. Hence, sometimes tests run even when > metastore isn't up and fail. > > > Diffs > ----- > > > hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java > 9fa263d53596378276fabc43b7f44409b4b0ccfb > > hcatalog/webhcat/java-client/src/test/java/org/apache/hive/hcatalog/api/TestHCatClient.java > aa9c7d31f2cbe187e84bfddfe411da1f49943819 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java > 7576f3923c7ae2e144263445d0a69e5424489567 > > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreGetMetaConf.java > 3f4561cc4b2a737f18e274779d6e748dcd3abad0 > > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java > 922a4bf11cbc5693cc5753b8488c5ae3085dd3f4 > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveRemote.java > ee95e160c858a93c43f96775b360f28f8d6a178f > > Diff: https://reviews.apache.org/r/46929/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
