----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47072/#review132095 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 5992) <https://reviews.apache.org/r/47072/#comment196190> This call can be delayed until we know its really a merge call and not overwrite. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 5997) <https://reviews.apache.org/r/47072/#comment196191> LOG.debug metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java (line 1801) <https://reviews.apache.org/r/47072/#comment196195> Can you add a comment saying: // This implies partition schema has changed. We will merge columns present in both, overwrite stats for columns absent in metastore and leave alone columns stats missing from stats task. This last case may leave stats in stale state. This will be addressed later. metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java (line 1802) <https://reviews.apache.org/r/47072/#comment196194> LOG.debug - Ashutosh Chauhan On May 6, 2016, 5:22 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47072/ > ----------------------------------------------------------- > > (Updated May 6, 2016, 5:22 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-13565 > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreStatsMerge.java > PRE-CREATION > metastore/if/hive_metastore.thrift c8d78b6 > metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 3b3e05e > metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 36a0f96 > > metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SetPartitionsStatsRequest.java > 6e334f6 > metastore/src/gen/thrift/gen-php/metastore/Types.php a8a7db9 > metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 8e0cb71 > metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 4d3e49d > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 9a09e7a > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > 76220f4 > > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/merge/BinaryColumnStatsMerger.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/merge/BooleanColumnStatsMerger.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/merge/ColumnStatsMerger.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/merge/ColumnStatsMergerFactory.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/merge/DecimalColumnStatsMerger.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/merge/DoubleColumnStatsMerger.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/merge/LongColumnStatsMerger.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/merge/StringColumnStatsMerger.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java 05dfa3b > > Diff: https://reviews.apache.org/r/47072/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
