----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47040/#review133140 -----------------------------------------------------------
shims/common/src/main/java/org/apache/hadoop/fs/FileWatchService.java (line 135) <https://reviews.apache.org/r/47040/#comment197440> Add a catch (Exception) so the executor doesn't die if there is an unchecked exception thrown for some reason. shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerShim.java (line 48) <https://reviews.apache.org/r/47040/#comment197464> Do we really need to cache this information? Comment on key/value for map. shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerShim.java (line 51) <https://reviews.apache.org/r/47040/#comment197442> Why do we need to track the last used location? Can't we just read the location once and use the the whole time? nit: don't need to initialize to null - Lenni Kuff On May 13, 2016, 3:26 p.m., Reuben Kuhnert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47040/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 3:26 p.m.) > > > Review request for hive, Lenni Kuff, Mohit Sabharwal, and Sergio Pena. > > > Bugs: HIVE-13696 > https://issues.apache.org/jira/browse/HIVE-13696 > > > Repository: hive-git > > > Description > ------- > > Ensure that jobs sent to YARN with impersonation off are correctly routed to > the proper queue based on fair-scheduler.xml. Monitor this file for changes > and validate that jobs can only be sent to queues authorized for the user. > > > Diffs > ----- > > shims/common/src/main/java/org/apache/hadoop/fs/FileWatchService.java > PRE-CREATION > shims/scheduler/pom.xml b36c12325c588cdb609c6200b1edef73a2f79552 > > shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerQueueAllocator.java > PRE-CREATION > > shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerShim.java > 372244dc3c989d2a3ae2eb2bfb8cd0a235705e18 > > shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/QueueAllocator.java > PRE-CREATION > > shims/scheduler/src/test/java/org/apache/hadoop/hive/schshim/TestFairScheduler.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47040/diff/ > > > Testing > ------- > > > Thanks, > > Reuben Kuhnert > >
