> On May 17, 2016, 10:01 p.m., Siddharth Seth wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java, line > > 376 > > <https://reviews.apache.org/r/46579/diff/4-5/?file=1385106#file1385106line376> > > > > Required here as well ?
remote one doesn't start threads; also see the comment on the cache field > On May 17, 2016, 10:01 p.m., Siddharth Seth wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java, line > > 347 > > <https://reviews.apache.org/r/46579/diff/4-5/?file=1385106#file1385106line347> > > > > null check required on the notification itself ? not as far as I can tell. Evne the value check is just paranoid, it's probably unneeded - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/#review133639 ----------------------------------------------------------- On May 17, 2016, 9:58 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46579/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 9:58 p.m.) > > > Review request for hive, Gunther Hagleitner, Siddharth Seth, and Vikram Dixit > Kumaraswamy. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 541af57 > llap-client/pom.xml 4a75bbb > llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapProxy.java > 424769f > > llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenClientFactory.java > PRE-CREATION > > llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenLocalClient.java > PRE-CREATION > llap-common/src/java/org/apache/hadoop/hive/llap/DaemonId.java 18355e6 > llap-common/src/java/org/apache/hadoop/hive/llap/LlapUtil.java ce03de0 > > llap-common/src/java/org/apache/hadoop/hive/llap/impl/LlapManagementProtocolClientImpl.java > cd11bdb > > llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapTokenProvider.java > edf9b18 > > llap-common/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java > PRE-CREATION > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java > 5731b2c > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java > db8bfa6 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java > f958bc4 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java > c54e726 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java fd6465a > > Diff: https://reviews.apache.org/r/46579/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
