----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47563/#review135873 -----------------------------------------------------------
llap-client/src/java/org/apache/hadoop/hive/llap/SubmitWorkInfo.java (line 44) <https://reviews.apache.org/r/47563/#comment200901> Remove TaskSpec from the cosntructor also, and a corresponding change in GenericUDTFGetSplits to construct TaskSpec only once if possible (otherwise that's a separate jira) llap-client/src/java/org/apache/hadoop/hive/llap/coordinator/LlapCoordinator.java (line 146) <https://reviews.apache.org/r/47563/#comment200905> Does this need to be volatile or an AtomicReference ? ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java (line 341) <https://reviews.apache.org/r/47563/#comment200902> I don't see where this is being enforced ? The signer is used irrespective of secure/non-secure. Are we going with the approach of sending a serialized VertexSpec in non-secure (without a signatre), or sending the TaskSpec ? Scratch that. Looks like it's being checked in createSignedVertexSpec. The comment still seems incorrect though, since TaskSpec is never sent any longer. Assuming the serialized spec without a signature works in LLAP (i.e. when the daemon gets the VertexSpecBinary without a signature - it handles it correctly) - Siddharth Seth On June 1, 2016, 9:23 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47563/ > ----------------------------------------------------------- > > (Updated June 1, 2016, 9:23 p.m.) > > > Review request for hive, Jason Dere and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > see JIRA. Please ignore the first iteration, RB doesn't allow base patches on > submit > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b2e6b6f > llap-client/src/java/org/apache/hadoop/hive/llap/SubmitWorkInfo.java > 6704294 > > llap-client/src/java/org/apache/hadoop/hive/llap/coordinator/LlapCoordinator.java > PRE-CREATION > llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapProxy.java > 6c2618b > > llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenLocalClient.java > af889b6 > > llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenLocalClientImpl.java > PRE-CREATION > llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapSigner.java > 478a40a > > llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapSignerImpl.java > PRE-CREATION > > llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapTokenLocalClient.java > PRE-CREATION > > llap-common/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java > 5aa4b84 > > llap-common/src/java/org/apache/hadoop/hive/llap/security/SigningSecretManager.java > 067a98e > llap-common/src/java/org/apache/hadoop/hive/llap/tez/Converters.java > e43b72b > llap-common/src/test/org/apache/hadoop/hive/llap/tez/TestConverters.java > 1df6df0 > > llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java > 4306c22 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java > d439c07 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSignerImpl.java > 4174593 > > llap-server/src/test/org/apache/hadoop/hive/llap/security/TestLlapSignerImpl.java > 0420225 > > llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java > 026df3b > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java d04cfa3 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java > 140dbda > service/src/java/org/apache/hive/service/server/HiveServer2.java d61edf5 > > Diff: https://reviews.apache.org/r/47563/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
