> On June 10, 2016, 1:11 a.m., Jason Dere wrote: > > llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java, > > line 135 > > <https://reviews.apache.org/r/48502/diff/1/?file=1412899#file1412899line135> > > > > Looks like a null tokenBytes is serialized/deserialized as a 0-byte > > array. During token verification does this get treated the same way as a > > null token?
Actually 0 bytes is deserialized as null - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48502/#review136949 ----------------------------------------------------------- On June 9, 2016, 7:07 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48502/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 7:07 p.m.) > > > Review request for hive, Jason Dere and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > . > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/llap/ext/TestLlapInputSplit.java > 7491222 > llap-client/src/java/org/apache/hadoop/hive/llap/LlapInputSplit.java > ab11926 > > llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java > 3ebae4a > > llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java > d1748cb > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java > cff5ee1 > > Diff: https://reviews.apache.org/r/48502/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
