----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48771/#review137988 -----------------------------------------------------------
Fix it, then Ship it! The code looks good for me. What other tests did you do to validate this code? - HS2 with KERBEROS + LDAP? - HS2 with KERBEROS only? - HS2 with LDAP only? service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java (line 231) <https://reviews.apache.org/r/48771/#comment203196> Should we return empty strings instead of nulls? That way we avoid that any other future developer uses this method without validating a null pointer, that could cause NPE if they do not do that. - Sergio Pena On June 16, 2016, 2:33 a.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48771/ > ----------------------------------------------------------- > > (Updated June 16, 2016, 2:33 a.m.) > > > Review request for hive. > > > Bugs: HIVE-13590 > https://issues.apache.org/jira/browse/HIVE-13590 > > > Repository: hive-git > > > Description > ------- > > Hive should not use Hadoop security (e.g. kerberos) related APIs such as > KerberosName etc to process user logged in via other SASL mechanism such as > LDAP. > > > Diffs > ----- > > > itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcNonKrbSASLWithMiniKdc.java > 1c1beda > service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java ab8806c > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 8bc3d94 > > shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java > 8a4786c > > Diff: https://reviews.apache.org/r/48771/diff/ > > > Testing > ------- > > Manual test > PreCommit test > > > Thanks, > > Chaoyu Tang > >
