-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48233/
-----------------------------------------------------------
(Updated June 23, 2016, 9:36 p.m.)
Review request for hive, Mohit Sabharwal and Naveen Gangam.
Changes
-------
Attaching new patch with changes on ObjectStore due to HIVE-14055
Bugs: HIVE-13884
https://issues.apache.org/jira/browse/HIVE-13884
Repository: hive-git
Description
-------
The patch verifies the # of partitions a table has before fetching any from the
metastore. I
t checks that limit from 'hive.limit.query.max.table.partition'.
A limitation added here is that the variable must be on hive-site.xml in order
to work, and it does not accept to set this through beeline because
HiveMetaStore.java does not read the variables set through beeline. I think it
is better to keep it this way to avoid users changing the value on fly, and
crashing the metastore.
Another change is that EXPLAIN commands won't be executed either. EXPLAIN
commands need to fetch partitions in order to create the operator tree. If we
allow EXPLAIN to do that, then we may have the same OOM situations for large
partitions.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
1d1306ff6395a0504085dda98e96c3951519f299
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
c0827ea9d47e569d9697649a7e16d196de3de14d
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
b809269d5b1775fcd57af62b254476627ab062cd
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
f67efcdf301b0e5e71ef1a4b7315b4184598d5b7
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java
a6d3f5385b33b8a4e31ee20ca5cb8f58c97c8702
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java
2f837bb12d4ced1e81fbd86a8104a16b9e3174a8
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
3152e77c3c7152ac4dbe7e779ce35f28044fe3c9
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
86a243609b23e2ca9bb8849f0da863a95e477d5c
Diff: https://reviews.apache.org/r/48233/diff/
Testing
-------
Waiting for HiveQA.
Thanks,
Sergio Pena
