> On July 13, 2016, 4:54 p.m., Gopal V wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java, > > line 227 > > <https://reviews.apache.org/r/49728/diff/1/?file=1438086#file1438086line227> > > > > The assumption about dropping locked blocks - does it ever happen that > > another thread has a valid reference to that block when this is hit?
LRFU policy does not need references for locked blocks because unlocking the block adds it back to the list/heap. However, this (removal) is not strictly enforced to avoid waiting/traversing when locking ie from processing thread every time. So the thread that already has to traverse removes them. It's not an eviction (eviction calls invalidate()) - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49728/#review142076 ----------------------------------------------------------- On July 6, 2016, 9:31 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49728/ > ----------------------------------------------------------- > > (Updated July 6, 2016, 9:31 p.m.) > > > Review request for hive and Gopal V. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java > 47325ad > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapCacheableBuffer.java > 5c0b6f3 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java > 4def4a1 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCachePolicy.java > acbaf85 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelFifoCachePolicy.java > 0838682 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java > 5a0b27f > llap-server/src/java/org/apache/hadoop/hive/llap/cache/MemoryManager.java > 6cc262e > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java > 345f5b1 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java > 0846db9 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java > 616c040 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestOrcMetadataCache.java > 40edb28 > > Diff: https://reviews.apache.org/r/49728/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
