----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49288/#review142125 -----------------------------------------------------------
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java (line 332) <https://reviews.apache.org/r/49288/#comment207629> can you also add a comment about what it is testing service/src/java/org/apache/hive/service/cli/operation/Operation.java (line 303) <https://reviews.apache.org/r/49288/#comment207631> The background thread in SQLOperation also calls these register/unregister methods. (there is probably some scope for cleanup there, specially with the new method in hivesession) Remove the TODO ? - Thejas Nair On July 13, 2016, 8:57 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49288/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 8:57 p.m.) > > > Review request for hive and Thejas Nair. > > > Repository: hive-git > > > Description > ------- > > . > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java bae1825 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > b0fa98f > > itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java > d58a913 > > service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java > ff46ed8 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 021c1fe > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > e453354 > service/src/java/org/apache/hive/service/cli/session/HiveSession.java > 78ff388 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > 7341635 > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java > f7b3412 > > Diff: https://reviews.apache.org/r/49288/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
