[ 
https://issues.apache.org/jira/browse/HIVE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147988#comment-13147988
 ] 

Phabricator commented on HIVE-2532:
-----------------------------------

jsichi has requested changes to the revision "HIVE-2532 [jira] Evaluation of 
non-deterministic/stateful UDFs should not be skipped even if constant oi is 
returned.".

INLINE COMMENTS
  
ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java:144
 Note that Java does not short-circuit the &= assignment.

  http://stackoverflow.com/questions/3152208/do-and-short-circuit-in-java
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluator.java:43 Need 
Javadoc here.

REVISION DETAIL
  https://reviews.facebook.net/D273

                
> Evaluation of non-deterministic/stateful UDFs should not be skipped even if 
> constant oi is returned.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2532
>                 URL: https://issues.apache.org/jira/browse/HIVE-2532
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>         Attachments: D273.1.patch, D273.2.patch
>
>
> Even if constant oi is returned, these may have stateful/side-effect behavior 
> and hence need to be called each cycle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to