----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50548/#review143977 -----------------------------------------------------------
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java (line 189) <https://reviews.apache.org/r/50548/#comment209916> nit - final? llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java (line 229) <https://reviews.apache.org/r/50548/#comment209917> can this check done before creating the reader? this basically creates the reader that is unusable (or unsafe) and then the caller has to double check. Perhaps caller should verify it before creating the reader instead. llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java (line 75) <https://reviews.apache.org/r/50548/#comment209918> cannot edc do it itself if needed? llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java (line 192) <https://reviews.apache.org/r/50548/#comment209920> hmm... this can be an expensive operation. llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java <https://reviews.apache.org/r/50548/#comment209921> why cannot the call be done here or in ctor? doesn't look like ctor does it. - Sergey Shelukhin On July 28, 2016, 3:38 a.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50548/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 3:38 a.m.) > > > Review request for hive and Sergey Shelukhin. > > > Bugs: HIVE-14355 > https://issues.apache.org/jira/browse/HIVE-14355 > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java > 9d16889 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ColumnVectorProducer.java > abd4533 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java > 7db519c > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java > 3dfab63 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ReadPipeline.java > 21b1772 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > 1dcd2cd > > Diff: https://reviews.apache.org/r/50548/diff/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
