-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50906/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-14444
https://issues.apache.org/jira/browse/HIVE-14444
Repository: hive-git
Description
-------
this patch focuses on removing the qtestgen task without introducing
regressions in existing testing services - its not the nicest patch...but opens
the possiblities to continue refactoring of these classes inside a pure java
environment
this patch contains a bunch of helper classes to provide Tests for the junit4
executor.
I've mimiced the old generated testcases behaviour:
* every test has a config entry in CliConfigs
* every config has a Core executor - these can be looked as the older vm files
* every test has an instance in the appropriate module - this class is
small...copy pasted parameterized junit4 test
Diffs
-----
ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java
f372d7cb937d91c10d3dff0e4c51e0849c5e3c9b
ant/src/org/apache/hadoop/hive/ant/antlib.xml
8f663482348448be9aadcf535c42a8c11d8955b1
hbase-handler/src/test/templates/TestHBaseCliDriver.vm
f513f0374b1e6798677e98b4d071d5969d204bfa
hbase-handler/src/test/templates/TestHBaseNegativeCliDriver.vm
043bd87a4f617de7fff89e38e654770cd9b84d8f
itests/qtest-accumulo/pom.xml 339c59919295b66c9d3c64a53ea78bd944e3a903
itests/qtest-spark/pom.xml 3bc9e24893a42bfcaab66d4cb8930dd5586c1db5
itests/qtest-spark/src/test/java/org/apache/hadoop/hive/cli/TestMiniSparkOnYarnCliDriver.java
PRE-CREATION
itests/qtest-spark/src/test/java/org/apache/hadoop/hive/cli/TestSparkCliDriver.java
PRE-CREATION
itests/qtest-spark/src/test/java/org/apache/hadoop/hive/cli/TestSparkNegativeCliDriver.java
PRE-CREATION
itests/qtest/pom.xml 17968e69559a16a1971f6028ea3073ab693a6678
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/ContribNegativeCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DummyCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestCompareCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestContribCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestContribNegativeCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestEncryptedHDFSCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestHBaseCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestHBaseMinimrCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestHBaseNegativeCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestMiniLlapCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestMiniTezCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestMinimrCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestNegativeCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestNegativeMinimrCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestPerfCliDriver.java
PRE-CREATION
itests/qtest/src/test/java/org/apache/hadoop/hive/ql/parse/TestParseNegativeDriver.java
PRE-CREATION
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCliConfig.java
PRE-CREATION
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliAdapter.java
PRE-CREATION
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java
PRE-CREATION
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreDummy.java
PRE-CREATION
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CorePerfCliDriver.java
PRE-CREATION
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java
b3cf6da56eddc5000515e5ebd34989e64b1c0010
pom.xml 0217edea03b71522629ec30514b67a4a5313edb6
ql/src/test/templates/TestBeeLineDriver.vm
563d7fd03600d391b5694cc8477562d9f2e5c9d9
ql/src/test/templates/TestCliDriver.vm
0ccedce7361fa87a72f369db90cd9c57dc8b26e2
ql/src/test/templates/TestCompareCliDriver.vm
8d4e96437c19177561f1d83ac4f22c16e98bfa93
ql/src/test/templates/TestNegativeCliDriver.vm
592d64f80b74ff76e897e2ae07f8635e46675932
ql/src/test/templates/TestParseNegative.vm
9500eced31d64e5029d9b2be429aaa6828252f11
ql/src/test/templates/TestPerfCliDriver.vm
d2946cb4f9a7e3e9f8b3cc14a75802a483e7f95a
Diff: https://reviews.apache.org/r/50906/diff/
Testing
-------
some manual tests for qfile, initScript ... they should work as before
ptests's use of minimr.test.files and such have caught me by surprise...but
those are also supported (i think)
Thanks,
Zoltan Haindrich
