[
https://issues.apache.org/jira/browse/HIVE-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148727#comment-13148727
]
John Sichi commented on HIVE-1040:
----------------------------------
Observation from Marek: also, if we include a snippet of the diff (maybe first
20 lines?) in the junit test report, that would be really useful. We don't
want to include the whole thing since it can be huge.
> use sed rather than diff for masking out noise in diff-based tests
> ------------------------------------------------------------------
>
> Key: HIVE-1040
> URL: https://issues.apache.org/jira/browse/HIVE-1040
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Affects Versions: 0.4.1
> Reporter: John Sichi
> Priority: Minor
>
> The current diff -I approach has two problems: (1) it does not allow
> resolution finer than line-level, so it's impossible to mask out pattern
> occurrences within a line, and (2) it produces unmasked files, so if you run
> diff on the command line to compare the result .q.out with the checked-in
> file, you see the noise.
> My suggestion is to first run sed to replace noise patterns with an
> unlikely-to-occur string like ZYZZYZVA, and then diff the pre-masked files
> without using any -I.
> This would require a one-time hit to update all existing .q.out files so that
> they would contain the pre-masked results.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
